-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify code path of DirichletBC::set
#3505
Merged
Merged
+75
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
reviewed
Nov 10, 2024
jorgensd
reviewed
Nov 10, 2024
jorgensd
reviewed
Nov 10, 2024
garth-wells
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just needs some small clarifications and simplifications.
garth-wells
reviewed
Nov 12, 2024
garth-wells
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces code duplicity in the
set
functionality of the Dirichlet boundary conditions.This also highlights, that in general the fundamental operation we need to implement to set a Dirichlet boundary condition is the one provided by the
set_fn
. So as long as one can define a mapping from index of Dirichlet boundary condition DOF to a coefficient value theDirichletBC::set
can be defined. Meaning in the future theDircihletBC
class orset
function may be altered to take a generalset_fn
instead of a specific type that contains the values - this would follow the functional style employed by the assembly routines and allow easy extension and remove the type dispatching within theDirichletBC
class.